feat: add database indexes to assessment_attempt for common query paths - #1386
Merged
RUKAYAT-CODER merged 1 commit intoAug 29, 2026
Merged
Conversation
|
@Horlarmmy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Horlarmmy
force-pushed
the
fix/add-assessment-attempt-indexes
branch
from
August 29, 2026 21:02
5477592 to
db8a2e6
Compare
Horlarmmy
force-pushed
the
fix/add-assessment-attempt-indexes
branch
from
August 29, 2026 21:10
db8a2e6 to
4a7997b
Compare
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add indexes to
assessment_attemptcovering its common lookup and foreign-key columns (#1229).Closes #1229
Problem
assessment_attempthad no indexes beyond the primary key. Columns used for lookups (studentId,assessmentId,status) forced sequential scans as the table grows.Changes
Entity (
src/assessment/entities/assessment-attempt.entity.ts):@Indexdecorators forstudentId,assessmentId,status, and a composite(studentId, assessmentId).Migration (
src/migrations/1802000000000-add-assessment-attempt-indexes.ts):CREATE INDEX IF NOT EXISTS.down()drops them in reverse order.IDX_assessment_attempt_studentId(studentId)IDX_assessment_attempt_assessmentId(assessmentId)IDX_assessment_attempt_status(status)IDX_assessment_attempt_studentId_assessmentId(studentId, assessmentId)Verification
tsc --noEmitpassesvalidate-migrations.jspasses (36 files)